On Tue, 10 May 2016 11:47:56 +0200, Jochen Henneberg wrote:
On Di, 2016-05-10 at 10:36 +0200, Takashi Iwai wrote:
On Mon, 09 May 2016 16:11:46 +0200, Takashi Iwai wrote:
On Mon, 09 May 2016 10:22:49 +0200, Jochen Henneberg wrote:
Hi,
it looks as if 'reconfig' feature is broken since the sysfs attributes have been moved to device attributes. In hda_sysfs.c:reconfig_codec() the device is cleared with snd_hda_codec_reset() which calls snd_hdac_device_unregister() which removes the sysfs entries (including the currently in-use 'reconfig'), the re-registration fails afterwards in snd_hda_codec_build_controls(). I am not sure when things got broken, but snd_hda_codec_reset() called from reconfig_codec() unregisters the device and removes the sysfs entries where in the past it only stripped all configurations (pcms, controls ...) from the device.
Hrm, OK, something got broken indeed there. I'll check it later.
Actually it's not about the sysfs, but rather the superfluous calls of snd_hda_codec_build_controls() & co. The fix patch is below.
Sorry for the confusion, I did not notice. Anyway, I have tested the patch with 4.5, changed codec hints, reconfig and no error messages and the changed hints have been respected after reconfig, looks good for me.
The patch has been merged now.
thanks,
Takashi