At Fri, 15 Jan 2010 19:02:17 +0530, Kunal Gangakhedkar wrote:
Thinking the logic again, however, it might be safer to check DMI entries no matter which model is. Then set statically if it's DV series (i.e. !hp_blike_system()) as fallback. I suppose HP will implement the DMI entry for their new BIOS on other models in future, too, so the chance is high that the right setup is detected through DMI check instead of blindly fixed setup.
They're notorious to discontinue models really fast. For example, my laptop model is already discontinued in less than 6 months. So, I don't think I'll be getting updates for my BIOS at all. What do you propose for such cases?
Sure, we'd need to do some static fixes. But checking DMI first is more or less "safer".
I agree with your approach that we should be checking for DMI string unconditionally and use the fixed setup as fallback - I can send the patch with those fixes too.
That'll be great.
thanks,
Takashi