At Wed, 5 Nov 2008 15:44:03 +1030, asto wrote:
Thanks. Could you give a summary line, a chnage log and your sign-off to merge to the upstream? See $LINUX/Documentation/SubmittingPatches for details.
New version of patch attached.
ASUS V1S should have digital out
SUMMARY: Asus V1s series laptops have an ALC660VD with PCI id: 0x1043, 0x1633. 1.) remove the previous behaviour of mapping that to the ALC861VD_LENOVO device. 2.) add a new ALC660VD_V1S device based on ALC861VD_LENOVO, with an added digital out. Signed-off-by: Tristan Aston astrotris@gmail.com
Thanks, applied now with a slight modification (ALC660VD_V1s -> ALC660VD_ASUS_V1S).
BTW, your patch couldn't be applied as is because your MUA seems to break tabs. Please fix MUA setting, or use an attachment if it's difficult.
Takashi
--- alsa-driver/alsa-kernel/pci/hda/patch_realtek.c.orig 2008-11-05 15:26:41.000000000 +1030 +++ alsa-driver/alsa-kernel/pci/hda/patch_realtek.c 2008-11-05 15:26:58.000000000 +1030 @@ -153,6 +153,7 @@ enum { enum { ALC660VD_3ST, ALC660VD_3ST_DIG,
ALC660VD_V1S, ALC861VD_3ST, ALC861VD_3ST_DIG, ALC861VD_6ST_DIG,@@ -13843,6 +13844,7 @@ static void alc861vd_dallas_unsol_event( static const char *alc861vd_models[ALC861VD_MODEL_LAST] = { [ALC660VD_3ST] = "3stack-660", [ALC660VD_3ST_DIG] = "3stack-660-digout",
[ALC660VD_V1S] = "v1s", [ALC861VD_3ST] = "3stack", [ALC861VD_3ST_DIG] = "3stack-digout", [ALC861VD_6ST_DIG] = "6stack-digout",@@ -13857,7 +13859,7 @@ static struct snd_pci_quirk alc861vd_cfg SND_PCI_QUIRK(0x103c, 0x30bf, "HP TX1000", ALC861VD_HP), SND_PCI_QUIRK(0x1043, 0x12e2, "Asus z35m", ALC660VD_3ST), SND_PCI_QUIRK(0x1043, 0x1339, "Asus G1", ALC660VD_3ST),
SND_PCI_QUIRK(0x1043, 0x1633, "Asus V1Sn", ALC861VD_LENOVO),
SND_PCI_QUIRK(0x1043, 0x1633, "Asus V1S", ALC660VD_V1S), SND_PCI_QUIRK(0x1043, 0x81e7, "ASUS", ALC660VD_3ST_DIG), SND_PCI_QUIRK(0x10de, 0x03f0, "Realtek ALC660 demo", ALC660VD_3ST), SND_PCI_QUIRK(0x1179, 0xff00, "Toshiba A135", ALC861VD_LENOVO),@@ -13895,6 +13897,21 @@ static struct alc_config_preset alc861vd .channel_mode = alc861vd_3stack_2ch_modes, .input_mux = &alc861vd_capture_source, },
[ALC660VD_V1S] = {.mixers = { alc861vd_lenovo_mixer },.init_verbs = { alc861vd_volume_init_verbs,alc861vd_3stack_init_verbs,alc861vd_eapd_verbs,alc861vd_lenovo_unsol_verbs },.num_dacs = ARRAY_SIZE(alc660vd_dac_nids),.dac_nids = alc660vd_dac_nids,.dig_out_nid = ALC861VD_DIGOUT_NID,.num_channel_mode = ARRAY_SIZE(alc861vd_3stack_2ch_modes),.channel_mode = alc861vd_3stack_2ch_modes,.input_mux = &alc861vd_capture_source,.unsol_event = alc861vd_lenovo_unsol_event,.init_hook = alc861vd_lenovo_automute,}, [ALC861VD_3ST] = { .mixers = { alc861vd_3st_mixer }, .init_verbs = { alc861vd_volume_init_verbs,