Re: [alsa-devel] [RFC][PATCH] ASoC: simple-card: Merge single and muti DAI link code.

...

---

Hi,

This patch will break the old DT, so i just send one RFC version, and will add the old DT patches in next version if this patch can work well.

Any comments and advices are welcome.

Hi Xiubo,

My DT is

sound { compatible = "simple-audio-card"; simple-audio-card,name = "Cubox Audio";

simple-audio-card,dai-link@0 {		/* I2S - HDMI */
	format = "i2s";
	cpu {
		sound-dai = <&audio1 0>;
	};
	codec {
		sound-dai = <&hdmi 0>;
	};
};

...

I was getting 0x1001 as the format (codec clk & FRM master and i2s').

With your patch, I get 0x4000 (clk master & frame slave and no format).

Well, yes, If your DAI link's bit clock & frame using the CODEC as master, You should specify it in your DAI link node like:

sound { compatible = "simple-audio-card"; simple-audio-card,name = "Cubox Audio";

simple-audio-card,dai-link@0 {		/* I2S - HDMI */
	format = "i2s";
	cpu {
		sound-dai = <&audio1 0>;
	};
	codec {
		sound-dai = <&hdmi 0>;
	};

bitclock-master; frame-master;

};

...

And the reason for cannot parsing the "i2s" format is that there is one bug in this patch and I will fix it in next version.

Thanks very much for your comment.

BRs Xiubo