Hi Rob,
On Fri, 22 Sep 2023 07:33:32 -0500 Rob Herring robh@kernel.org wrote:
On Fri, 22 Sep 2023 09:59:00 +0200, Herve Codina wrote:
The Lantiq PEF2256 is a framer and line interface component designed to fulfill all required interfacing between an analog E1/T1/J1 line and the digital PCM system highway/H.100 bus.
Signed-off-by: Herve Codina herve.codina@bootlin.com Reviewed-by: Christophe Leroy christophe.leroy@csgroup.eu
.../bindings/net/lantiq,pef2256.yaml | 214 ++++++++++++++++++ 1 file changed, 214 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/lantiq,pef2256.yaml
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/lantiq,pef2256.yaml: properties:lantiq,data-rate-bps: '$ref' should not be valid under {'const': '$ref'} hint: Standard unit suffix properties don't need a type $ref from schema $id: http://devicetree.org/meta-schemas/core.yaml#
The '-bps' suffix was added recently in https://github.com/devicetree-org/dt-schema/ commit 033d0b1 ("Add '-bps' as a standard unit suffix for bits per second")
This commit is not yet present in any dt-schema release.
Should I update my patch (ie. removing $ref) right now even if this update will make the last dt-schema release not happy ?
Regards, Hervé