On Mon, May 11, 2009 at 10:38 AM, Takashi Iwai tiwai@suse.de wrote:
First off, please give a text as a change log together with your sign-off so that the patch can be merged to the upstream.
Here it is: ===== Add specific configuration for Samsung NC10 mini notebook. Internal mic/speakers will be correctly muted when plugging in external ones. Mixer controls are added for speakers, headphones and PC beep. "Boost" is added for the microphones. Signed-off-by: Chris Pockelé <chris.pockele.f1@gmail.com > =====
... This kind of comment isn't needed because we track all changes via GIT.
It's gone now.
If you'd like to keep the test code, just comment out with some other ifdef. Even an ifdef 0 with a comment would be OK.
Ok, did that.
...
- HDA_CODEC_VOLUME("Ext Mic Boost Playback Volume", 0x18, 0, HDA_INPUT),
The mic boost is for both playback and capture. Thus, simply name it as "... Mic Boost".
- HDA_CODEC_VOLUME("Int Mic Playback Volume", 0x0b, 0x1, HDA_INPUT),
- HDA_CODEC_MUTE("Int Mic Playback Switch", 0x0b, 0x1, HDA_INPUT),
- HDA_CODEC_VOLUME("Int Mic Boost Playback Volume", 0x19, 0, HDA_INPUT),
Ditto.
Changed the names.
[ALC663_ASUS_MODE6] = "asus-mode6",
- [ALC272_DELL] = "dell272",
- [ALC272_DELL_ZM1] = "dell-zm1",
These models have been already added pretty recently. Please rebase your patch with the latest snapshot.
I rebased using 20090509 snapshot before sending the patch (I checked out today's snapshot too - patch_realtek.c hasn't changed), and those models were there indeed. However, I wanted to try those configurations but I couldn't use the model= option because the configurations were not in the alc662_models array. That's why I added these 2 lines, and it got through to the patch. I removed them for now, as that should probably be another patch.
- [ALC272_SAMSUNG_NC10] = "samsung-nc10",
Also, don't forget to update Documentation/sound/alsa/HD-Audio-Models.txt, too.
Could you fix the issues above and repost?
The attached version fixes all issues you mentioned.
Regards, Chris