On Wed, Jan 24, 2018 at 05:14:40PM +0000, Charles Keepax wrote:
On Wed, Jan 24, 2018 at 04:05:51PM +0000, Mark Brown wrote:
On Wed, Jan 24, 2018 at 04:00:29PM +0000, Charles Keepax wrote:
On Wed, Jan 24, 2018 at 03:33:30PM +0000, Mark Brown wrote:
This doesn't apply against Linus' tree so that's not going to happen...
Shall I split it into a crufty fix and then a tidy up?
Without seeing how awkward the crufty fix looks it's hard to say, use your judgement.
My feeling is still the same really that we should stick with this patch even though its a bit more to put into stable, since really the looping stuff is a bug as well.
But that said I will have a go at drafting up a separated patch, see what it looks like and report back tomorrow.
A simpler fix does indeed apply to Linus's tree, given there is also still some discussion on the patch I will split the patch into the copy fix and the separate refactoring so we can get the fix in now.
Thanks, Charles