Re: [alsa-devel] [PATCH 2/3] ALSA SoC: Add mpc5200-psc I2S driver

On Fri, Jul 04, 2008 at 07:03:25AM -0400, Timur Tabi wrote:

...

i2s@2200 { // PSC2 compatible = "fsl,mpc5200b-psc-i2s","fsl,mpc5200-psc-i2s"; cell-index = <1>;

cell-index should be zero-based, not one-based.

Well...since cell-index is for indexing shared resources, the cell-index values should be whatever the convention is for that shared resource, which can be defined as whatever is convenient for that resource. I think that's been zero-based in every user of cell-index so far, but there's no reason it *has* to be if a different enumeration is convenient for the shared resource in question.