Re: [alsa-devel] [PATCH 03/17] firewire-lib: Add 'direction' member to 'amdtp_stream' structure

Takashi Sakamoto wrote:

This patch adds 'direction' member to amdtp_stream structure to indicate its direction.

+++ b/sound/firewire/amdtp.h

+enum amdtp_stream_direction {

• AMDTP_RECEIVE_STREAM = 0,
• AMDTP_TRANSMIT_STREAM

+};

We have two FireWire nodes, the PC and the audio device. Both streams are transmitted by a node and received by a node, so these names does not actually specify a direction.

The DMA API uses names like DMA_FROM/TO_DEVICE for this. Alternatively, you could use something like PLAYBACK/CAPTURE.

Regards, Clemens