On Fri, Oct 31, 2014 at 06:31:23PM +0100, Takashi Iwai wrote:
At Fri, 31 Oct 2014 18:15:36 +0530, Sudip Mukherjee wrote:
On Tue, Oct 28, 2014 at 05:45:12PM +0100, Takashi Iwai wrote:
Hi,
it's a small series to get rid of snd_print*() usages in a few PCI sound drivers. There remain still a few, I know, but this is just a matter of cleanup, so let them be there...
hi, still there is approx. 723 usages of snd_printk (including snd_printk in comments), and including 46 in PCI. shall i do the cleanups for you ?
Only you have really free time and gut :) The problem is rather inconsistencies, i.e. if the same module has a mix of dev_*() and snd_printk() (or snd_printd()), they should be replaced as well. If not mixed, we can leave as is for now.
i am having one doubt. I saw in your patch you have replaced snd_printdd with dev_dbg and snd_printd with dev_info. but when i am checking the macro of snd_printd or snd_printdd , i see that they are also printing the file and line along with the message. snd_printddd is also doing the same thing. then while replacing them with dev_*, the file and line are not required ?
thanks sudip
snd_printdd() is a slight different story. It's really a debug print, so do it only when easily possible.
Takashi