Hi,
On 10/25/22 16:29, Pierre-Louis Bossart wrote:
On 10/25/22 09:09, Hans de Goede wrote:
The Nanote UMPC-01 mini laptop has stereo speakers, while the default bytcht_es8316 settings assume a mono speaker setup. Add a quirk for this.
Signed-off-by: Hans de Goede hdegoede@redhat.com
sound/soc/intel/boards/bytcht_es8316.c | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/sound/soc/intel/boards/bytcht_es8316.c b/sound/soc/intel/boards/bytcht_es8316.c index 6432b83f616f..a935c5fd9edb 100644 --- a/sound/soc/intel/boards/bytcht_es8316.c +++ b/sound/soc/intel/boards/bytcht_es8316.c @@ -443,6 +443,13 @@ static const struct dmi_system_id byt_cht_es8316_quirk_table[] = { | BYT_CHT_ES8316_INTMIC_IN2_MAP | BYT_CHT_ES8316_JD_INVERTED), },
- { /* Nanote UMPC-01 */
.matches = {DMI_MATCH(DMI_SYS_VENDOR, "RWC CO.,LTD"),DMI_MATCH(DMI_PRODUCT_NAME, "UMPC-01"),},.driver_data = (void *)BYT_CHT_ES8316_INTMIC_IN1_MAP,the commit massage talks about a mono speaker, this quirk changes the microphone setup. Is the quirk correct?
The default quirk for a CHT es8316 codec using device is:
} else { /* Others default to internal-mic-in1-map, mono-speaker */ quirk = BYT_CHT_ES8316_INTMIC_IN1_MAP | BYT_CHT_ES8316_MONO_SPEAKER; }
So this just drops the BYT_CHT_ES8316_MONO_SPEAKER from the default quirks.
Yes defaulting to mono is a bit weird, but the es8316 is mostly used in very low budget devices which often have only 1 speaker.
Regards,
Hans
- }, { /* Teclast X98 Plus II */ .matches = { DMI_MATCH(DMI_SYS_VENDOR, "TECLAST"),