Re: [alsa-devel] [RFC 12/14] regmap: SoundWire: Add regmap support for SoundWire bus

On Fri, Oct 21, 2016 at 06:11:10PM +0530, Hardik Shah wrote:

+static inline void get_t_size(size_t *t_val_size, size_t *t_size,

• 				int *reg_addr,
  

• 				int *offset,
  

• 				size_t *val_size)
  

+{

• *t_val_size += *t_size;
  

• *offset += *t_size;
  

So, I started by taking a look at this patch to get a sense of what the API would look like and I see that we're not following CodingStyle with everything indented twice :(

+static int regmap_sdw_gather_write(void *context,

• 	   const void *reg, size_t reg_size,
  

• 	   const void *val, size_t val_size)
  

+{

• if (!sdw)

• return 0;
  

Silently ignoring errors :(

• if (val_size > SDW_MAX_REG_ADDR)

• t_size = SDW_MAX_REG_ADDR - reg_command;
  

• else

• t_size = val_size;
  

This needs at least some kind of comment?