Re: [alsa-devel] [PATCH v2 2/9] ASoC: da7210: Add support for line input and mic

On Thu, 2011-10-13 at 17:19 +0100, Mark Brown wrote:

On Thu, Oct 13, 2011 at 07:34:04PM +0530, Ashish Chavan wrote:

...

} else {

• /* Volume 7 */
  

• snd_soc_update_bits(codec, DA7210_MIC_L, 0x7, 0x7);
  

• snd_soc_update_bits(codec, DA7210_MIC_R, 0x7, 0x7);
  

• /* Enable Mic */
  

• snd_soc_update_bits(codec, DA7210_INMIX_L, 0x1F, 0x1);
  

• snd_soc_update_bits(codec, DA7210_INMIX_R, 0x1F, 0x1);
  

• /* Enable Mic,AUX1 and AUX2 */
  

• snd_soc_update_bits(codec, DA7210_INMIX_L, 0x1F, 0xD);
  

• snd_soc_update_bits(codec, DA7210_INMIX_R, 0x1F, 0xD);
  

So, I did mention that the DAPM patch should come first when I reviewed your previous series...

Posted the series after rearranging the sequence and removing already merged patch.

Thanks for your time.