Hi Takashi,
On Fri, Mar 18, 2011 at 9:44 AM, Takashi Iwai tiwai@suse.de wrote:
At Tue, 15 Mar 2011 10:45:19 -0600, Margarita Olaya wrote:
This allows devices value to be read using the get_value(). Also fix a little formatting.
Signed-off-by: Margarita Olaya Cabrera magi@slimlogic.co.uk
src/ucm/main.c | 19 +++++++++++++------ 1 files changed, 13 insertions(+), 6 deletions(-)
diff --git a/src/ucm/main.c b/src/ucm/main.c index 42fd373..fb11e61 100644 --- a/src/ucm/main.c +++ b/src/ucm/main.c @@ -1063,20 +1063,27 @@ static int get_value3(const char **value, * \return Zero on success (value is filled), otherwise a negative error code */ static int get_value(snd_use_case_mgr_t *uc_mgr,
- const char *identifier,
- const char **value,
- const char *modifier)
- const char *identifier,
- const char **value,
- const char *item)
Please fix also the corresponding DocBook comment when you change the parameter (and semantics).
- dev = find_device(uc_mgr->active_verb, item);
- if (dev != NULL) {
- err = get_value1(value, &dev->value_list, identifier);
- if (err >=0 || err != -ENOENT)
Put a space after '>='.
Could you resubmit with these fixes?
Thanks for review, I will resubmit the patch shortly :)
Regards, Margarita
thanks,
Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel