Re: [PATCH v2] ALSA: ASoC/tas2781: fix wrong calibrated data order

On Tue, Aug 13, 2024 at 12:37:48PM +0800, Shenghao Ding wrote:

From: Baojun Xu baojun.xu@ti.com

Wrong calibration data order cause sound too low in some device. Fix wrong calibrated data order, add calibration data converssion by get_unaligned_be32() after reading from UEFI.

...

	rc = tasdevice_dev_bulk_write(tas_priv, i,
		TASDEVICE_REG(0, page_array[j], rgno_array[j]),

• 		&(data[4 * j]), 4);
  

• 		(unsigned char *)&data, 4);
  

Casting is not needed if the helper is written in a way how regmap IO accessors done.

In any case, 4 is sizeof(data)

• 	offset += 4;
  

Ditto.