Re: [alsa-devel] [PATCH 1/2] ASoC: fsi: simultaneous playback/recorde support

On Tue, 2010-10-12 at 18:33 +0900, Kuninori Morimoto wrote:

Dear Liam

Thank you for your checking patch

...

...

+/* is */ +#define IS_PLAY 1 +#define IS_CAPTURE 0

Please use SNDRV_PCM_STREAM_PLAYBACK and SNDRV_PCM_STREAM_CAPTURE here.

understand but ... I think SNDRV_PCM_STREAM_PLAYBACK = 0 SNDRV_PCM_STREAM_CAPTURE = 1

But in fsi driver, IS_PLAY needs 1, IS_CAPTURE needs 0 for now. should I modify all of these ?

Yes, we need to keep consistency with ALSA.

Thanks

Liam