On Tue, Apr 21, 2015 at 11:41:48AM +0000, Bard Liao wrote:
OK, you probaly want to move to separate default tables per device. This is something that should have been called out in the commit log.
Do you mean we need to write it down in the commit log and send another patch to use separate default tables for different device?
Yes, that's fine.
Regarding the different default tables, do you mean something like: case RT5645_DEVICE_ID: rt5645->codec_type = CODEC_TYPE_RT5645; dev_info(&i2c->dev, "Codec type is: RT5645\n");
rt5645_regmap. reg_defaults = rt5645_reg;rt5645_regmap. reg_defaults = rt5650_reg;
It'd be better to have different regmap_config structures rather than changing the register defaults in the one structure but basically yes.
OK, can we have a comment for that please? We might want to extend this in the future as the userspace ABI grows richer (and depending on how things get reported we may need to synthesize at least a double press for userspace).
Do you mean comment in the source code?
Yes, please.