12 Dec
2018
12 Dec
'18
3:48 p.m.
Thanks for the reviews Takashi.
On 12/12/18 6:04 AM, Takashi Iwai wrote:
On Tue, 11 Dec 2018 22:30:14 +0100, Pierre-Louis Bossart wrote:
+int hda_dsp_resume(struct snd_sof_dev *sdev) +{
- struct hdac_bus *bus = sof_to_bus(sdev);
- int ret;
- /* turn display power on */
- ret = hda_codec_i915_get(sdev);
OK, we need to change this one for following my latest HD-audio PM refactoring...
Yes, it's already tracked as an item to fix. We might change the name even since there is no reference count any longer, so something like hda_codec_i915_power would make more sense.
- if (ret < 0) {
dev_err(bus->dev, "error: cannot turn on display power on i915 after resume\n");return ret;- }
- /* init hda controller and power dsp up */
- return hda_resume(sdev);
+}
+int hda_dsp_runtime_resume(struct snd_sof_dev *sdev) +{
- /* init hda controller and power dsp up */
- return hda_resume(sdev);
+}
But why can't runtime PM turn on/off the display power?
I think it does? We'll double-check this.