Re: [PATCH v15 29/50] ALSA: usb-audio: qcom: Introduce QC USB SND offloading support

On Tue, 13 Feb 2024 01:54:01 +0100, Wesley Cheng wrote:

+static int __init qc_usb_audio_offload_init(void) +{

• struct uaudio_qmi_svc *svc;
• int ret;
• svc = kzalloc(sizeof(struct uaudio_qmi_svc), GFP_KERNEL);
• if (!svc)

• return -ENOMEM;
  

• svc->uaudio_wq = create_singlethread_workqueue("uaudio_svc");
• if (!svc->uaudio_wq) {

• ret = -ENOMEM;
  

• goto free_svc;
  

• }

Do we need a dedicated workqueue? I don't mind much, but an own workqueue isn't usually needed unless specifically required such as the request quantity control or isolation.

thanks,

Takashi