Re: [PATCH] ALSA: hda/realtek: Remove Framework Laptop 16 from quirks

Thanks Dustin and Kieran. This approach makes sense to me then.

Reviewed-by: Mario Limonciello mario.limonciello@amd.com

On 6/5/2024 6:15 PM, Kieran Levin wrote:

The audio expansion card has a full usb to headphone jack codec. So does not interact with HDA at all.

On Thu, Jun 6, 2024, 1:11 AM Dustin Howett <dustin@howett.net mailto:dustin@howett.net> wrote:

On Wed, Jun 5, 2024 at 12:03 PM Mario Limonciello
<mario.limonciello@amd.com <mailto:mario.limonciello@amd.com>> wrote:
 >
 > On 6/5/2024 12:01, Dustin L. Howett wrote:
 > > The Framework Laptop 16 does not have a combination
headphone/headset
 > > 3.5mm jack; however, applying the pincfg from the Laptop 13
(nid=0x19)
 > > erroneously informs hda that the node is present.
 >
 > But doesn't the audio card work this way?

I don't believe so - the audio expansion card enumerates as a USB
device that is picked up by snd-usb-audio.
A headset microphone connected to the audio expansion card seems to
continue working properly even with this pinctrl change (synthetically
tested on my Framework Laptop 13, mind you -- it is not a perfect test
:)).

d