3 Sep
2021
3 Sep
'21
11:10 p.m.
On 8/17/21 4:31 AM, Charles Keepax wrote:
On Mon, Aug 16, 2021 at 05:43:09PM -0500, David Rhodes wrote:
+static int cs35l41_component_probe(struct snd_soc_component *component) +{
- struct cs35l41_private *cs35l41 =
snd_soc_component_get_drvdata(component);- component->regmap = cs35l41->regmap;
You sure this is necessary? The core should do this for us, its only necessary if the regmap is on a different struct device to the CODEC which isn't the case in this driver. Also if this is necessary it should be using snd_soc_component_init_regmap.
Not necessary. As far as I can tell this is just a relic of something long since refactored.
I agree with all the other comments as well and I will include in v6.
Thanks, David