Re: [PATCH 2/3] ASoC: sun50i-codec-analog: Add support for internal bias

On Thu, Jun 16, 2022 at 01:25:53AM -0500, Samuel Holland wrote:

+static int sun50i_a64_codec_probe(struct snd_soc_component *component) +{

• struct sun50i_codec_analog *codec = snd_soc_component_get_drvdata(component);
• regmap_update_bits(component->regmap, SUN50I_ADDA_JACK_MIC_CTRL,

• 	   BIT(SUN50I_ADDA_JACK_MIC_CTRL_INNERRESEN),
  

• 	   codec->internal_bias_resistor <<
  

• 		SUN50I_ADDA_JACK_MIC_CTRL_INNERRESEN);
  

• return 0;

+}

It doesn't make much practical difference but is there any reason this can't be done in the main device probe?