On 06/20/2016 07:49 PM, Rob Herring wrote:
- samsung,i2s-controller : the phandle of the I2S controller
- samsung,speaker-amplifier : the phandle of the MAX98504 amplifier
I'm considering changing this to a more generic (samsung,?)audio-amplifier in next iteration. Or maybe just listing MAX98504 as second entry of the (samsung,)audio-codec(s) property value, since capabilities and functionality of the device in the system is not limited to just simple audio power amplification. It accepts analogue audio signal on its input and is transmitting digital audio data stream in the feedback path to the WM5110 codec's DSP.
We should have standard properties for these. 2nd ones I've seen today.
No, these aren't fixed roles in a system, you couldn't have standard handling for them.
What do you mean? It is silly for us to put vendor prefixes on all of these. There are dozens of examples in the binding docs of <vendor>,i2s-controller and <vendor>,audio-codec. Yes, dropping just the vendor prefix doesn't buy much (maybe some string space), but it certainly adds nothing.
It also looked unnecessary to me to at first sight to be adding vendor prefixes to those properties. We could look at the compatible string in the pointed node for handling any differences.