Re: [alsa-devel] [PATCH 06/14] ASoC: Add sun8i digital audio codec

Hi,

On Tue, Oct 04, 2016 at 02:40:08PM +0200, Thomas Petazzoni wrote:

...

• scodec->clk_apb = devm_clk_get(&pdev->dev, "apb");
• if (IS_ERR(scodec->clk_apb)) {

• dev_err(&pdev->dev, "Failed to get the apb clock\n");
  

• return PTR_ERR(scodec->clk_apb);
  

• }
• if (clk_prepare_enable(scodec->clk_apb))

• pr_err("err:open failed;\n");
  

Ditto. + unprepare/disable the previous clock.

Ideally, that would be even not be part of the runtime_pm hooks. Ideally, that would be great if that driver supports it.

We'll have to go through all the drivers to support it, that would be one less to do (and ASoC makes it very easy, you can have a look at the sun4i-i2s driver).

Thanks! Maxime