Re: [PATCH v1 1/3] ASoC: Add ESS ES9218P codec driver

On 10/05/2023 13:23, Aidan MacDonald wrote:

The ES9218P is a 32-bit stereo codec featuring an integrated headphone amp with analog volume control and up to 2.0 V rms output, and a low-power bypass path for passing through an analog signal from an alternate source.

The digital audio interface supports 16/24/32-bit I2S inputs ranging from 8 KHz to 384 KHz, and DSD inputs. This driver only supports I2S operation.

...

+static const struct of_device_id es9218p_of_match[] = {

• { .compatible = "ess,es9218p" },
• { }

+}; +MODULE_DEVICE_TABLE(of, es9218p_of_match);

+static const struct i2c_device_id es9218p_i2c_id[] = {

• { "ess-es9218p", 0 },
• { }

+}; +MODULE_DEVICE_TABLE(i2c, es9218p_i2c_id);

+static struct i2c_driver es9218p_i2c_driver = {

• .driver = {

• .name = "ess-es9218p",
  

• .of_match_table = of_match_ptr(es9218p_of_match),
  

Drop of_match_ptr or add __maybe_unused to the table.

Best regards, Krzysztof