-----Original Message----- From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com] Sent: Wednesday, February 09, 2011 5:42 PM To: Koul, Vinod Cc: alsa-devel@alsa-project.org; lrg@slimlogic.co.uk; Harsha, Priya Subject: Re: [PATCH 1/3] ASoC: sn95031: Add jack support in the codec
On Wed, Feb 09, 2011 at 02:42:25PM +0530, Koul, Vinod wrote:
+void disable_jack_btn(struct snd_soc_codec *codec) +{
- snd_soc_write(codec, SN95031_BTNCTRL2, 0x00);
+} +EXPORT_SYMBOL_GPL(disable_jack_btn);
This needs to be namespaced. It's also surprising that the matching enable function isn't exposed...
Yes, that's right, this should be namespaced :)
This buttons are disabled at init, but I added code to check jack status at init, If it finds a avalid check it will enabled jack or disable otherwise.
I don't strictly need this. I will remove this as exported and fix namespace...
The code itself looks OK.
In that case would it be okay if you accept this and I will send follow patch right away fixing this...Or I will resend all three?
~Vinod