On Wed, 06 Feb 2019 10:07:21 +0100, Jaroslav Kysela wrote:
Dne 5.2.2019 v 20:42 Takashi Iwai napsal(a):
Hi,
this is yet another patchset for trivial cleanups. At this time, it's about the superfluous error check from snd_pcm_lib_preallocate_pages() and co. They always succeed and never return a failure although many codes do the error check. The patches simply remove the error checks and finally change the function to be void function.
The patches are applied on top of my previous NULL device fix patches, so not applicable to ASoC tree, I guess. As all these are trivial, applying through my tree altogether would be simpler.
So, Mark, please give your ACK if the changes to ASoC drivers are OK.
With all respects, do we really need to split those elementary changes to single patches inside the sound tree? I would really prefer to have this inside one patch or maybe few patches (core/pci/asoc/others). Just my two cents.
Reviewed-by: Jaroslav Kysela perex@perex.cz
There are both good and bad sides by this kind of fine splits. A good side is that each reviewer can give ack for particular changes, and it's easier to backport to older kernels. A bad side is that it results in more commits, and the relation between all relevant changes isn't clear from each single commit.
I split at this time, especially about ASoC, since ASoC codes are managed by more people than other parts in the sound tree. But, yeah, this could be a single patch, too.
thanks,
Takashi