Hi Jackie,
On Sat, Sep 18, 2021 at 7:17 AM Jackie Liu liu.yun@linux.dev wrote:
From: Jackie Liu liuyun01@kylinos.cn
After compiling with COMPILE_TEST, we are most likely to compile on a different architecture, such as x86. At this time, it is possible that the HAVE_CLK macro is not selected, resulting in compilation failure.
Avoid fail like:
Kernel: arch/x86/boot/bzImage is ready (#17) ERROR: modpost: "clkdev_add" [sound/soc/mediatek/mt8195/snd-soc-mt8195-afe.ko] undefined! ERROR: modpost: "clkdev_drop" [sound/soc/mediatek/mt8195/snd-soc-mt8195-afe.ko] undefined! ERROR: modpost: "clk_unregister_gate" [sound/soc/mediatek/mt8195/snd-soc-mt8195-afe.ko] undefined! ERROR: modpost: "clk_register_gate" [sound/soc/mediatek/mt8195/snd-soc-mt8195-afe.ko] undefined! make[1]: *** [scripts/Makefile.modpost:134: modules-only.symvers] Error 1 make[1]: *** Deleting file 'modules-only.symvers' make: *** [Makefile:1783: modules] Error 2
Cc: Geert Uytterhoeven geert+renesas@glider.be Fixes: 940ffa194547 ("ASoC: mediatek: SND_SOC_MT8195 should depend on ARCH_MEDIATEK") Signed-off-by: Jackie Liu liuyun01@kylinos.cn
Thanks for your patch!
--- a/sound/soc/mediatek/Kconfig +++ b/sound/soc/mediatek/Kconfig @@ -187,7 +187,7 @@ config SND_SOC_MT8192_MT6359_RT1015_RT5682
config SND_SOC_MT8195 tristate "ASoC support for Mediatek MT8195 chip"
depends on ARCH_MEDIATEK || COMPILE_TEST
depends on ARCH_MEDIATEK
Instead of dropping support for compile-testing, wouldn't it be better to add the missing real dependencies?
HAVE_CLK (clkdev_add, clkdev_drop) COMMON_CLK (clk_unregister_gate, clk_register_gate)
As the latter selects the former, adding the line
depends on COMMON_CLK
Also, the Fixes line is wrong as the link failure happened before. Fixes: 6746cc858259985a ("ASoC: mediatek: mt8195: add platform driver")
select SND_SOC_MEDIATEK help This adds ASoC platform driver support for Mediatek MT8195 chip
Gr{oetje,eeting}s,
Geert