On Thu, Nov 05, 2020 at 09:12:51AM -0800, Dan Williams wrote:
On Thu, Nov 5, 2020 at 1:47 AM Leon Romanovsky leonro@nvidia.com wrote:
On Thu, Nov 05, 2020 at 01:19:09AM -0800, Dan Williams wrote:
Some doc fixups, and minor code feedback. Otherwise looks good to me.
On Thu, Oct 22, 2020 at 5:35 PM Dave Ertman david.m.ertman@intel.com wrote:
<...>
+config AUXILIARY_BUS
booltristate? Unless you need non-exported symbols, might as well let this be a module.
I asked it to be "bool", because bus as a module is an invitation for a disaster. For example if I compile-in mlx5 which is based on this bus, and won't add auxiliary_bus as a module to initramfs, the system won't boot.
Something is broken if module dependencies don't arrange for auxiliary_bus.ko to be added to the initramfs automatically, but yes, it is another degree of freedom for something to go wrong if you build the initramfs by hand.
And this is something that I would like to avoid for now.
<...>
Per above SPDX is v2 only, so...
Isn't it default for the Linux kernel?
SPDX eliminated the need to guess a default, and MODULE_LICENSE("GPL") implies the "or later" language. The only default assumption is that the license is GPL v2 compatible, those possibilities are myriad, but v2-only is the first preference.
I mean that plain GPL == GPL v2 in the kernel.
Thanks