On 6/13/08, Mark Brown broonie@opensource.wolfsonmicro.com wrote:
On Fri, Jun 13, 2008 at 07:17:42AM -0500, Timur Tabi wrote:
Jon Smirl wrote:
On 6/12/08, Jon Smirl jonsmirl@gmail.com wrote:
Instead the codec should make a module parameter for the clock rate.
Ugh. I'm not really crazy about parameters.
Yes, that doesn't seem too clever.
Besides, the codec drivers need to treat all the clocking configuration as dynamic - for example, it's a fairly common pattern for systems that derive the audio clocks from a PLL or similar source to reconfigure the master clock rate depending on the sample rates currently in use, disabling it when not required.
My system works like you describe. We have an external clock generator. It needs to be set up in the fabric code.
Isn't the parameter needed for codecs like AC97 where they supply the clock back to the CPU? Timur's device tree is the one with a codec clock rate. Are there other parameters the system might need to set into a codec?