Like I say it's not that patch that's causing the break, I didn't walk through and work out which one was - the patch isn't actually adding the usage or anything.
Ah yes, you're correct. Mea culpa. We're using the parameter for HDA and SoundWire now, but HDA is disabled with allmodconfig due to a mutual exclusion with NOCODEC. I've had this on my todo list for a while.
We need something like this, will test and resend a v2. Sorry about the noise.
diff --git a/sound/soc/sof/intel/hda.c b/sound/soc/sof/intel/hda.c index 2014058bddf2..0dc3a8c0f5e3 100644 --- a/sound/soc/sof/intel/hda.c +++ b/sound/soc/sof/intel/hda.c @@ -285,11 +285,13 @@ static char *hda_model; module_param(hda_model, charp, 0444); MODULE_PARM_DESC(hda_model, "Use the given HDA board model.");
-#if IS_ENABLED(CONFIG_SND_SOC_SOF_HDA) +#if IS_ENABLED(CONFIG_SND_SOC_SOF_HDA) || IS_ENABLED(CONFIG_SND_SOC_SOF_INTEL_SOUNDWIRE) static int hda_dmic_num = -1; module_param_named(dmic_num, hda_dmic_num, int, 0444); MODULE_PARM_DESC(dmic_num, "SOF HDA DMIC number"); +#endif
+#if IS_ENABLED(CONFIG_SND_SOC_SOF_HDA) static bool hda_codec_use_common_hdmi = IS_ENABLED(CONFIG_SND_HDA_CODEC_HDMI); module_param_named(use_common_hdmi, hda_codec_use_common_hdmi, bool, 0444); MODULE_PARM_DESC(use_common_hdmi, "SOF HDA use common HDMI codec driver");