Re: [alsa-devel] [RFC PATCH 09/40] soundwire: cadence_master: fix usage of CONFIG_UPDATE

On 2019-07-26 01:40, Pierre-Louis Bossart wrote:

/*

• debugfs

*/ @@ -758,15 +774,9 @@ static int _cdns_enable_interrupt(struct sdw_cdns *cdns) */ int sdw_cdns_enable_interrupt(struct sdw_cdns *cdns) {

• int ret;

• _cdns_enable_interrupt(cdns);

• ret = cdns_clear_bit(cdns, CDNS_MCP_CONFIG_UPDATE,

• 	     CDNS_MCP_CONFIG_UPDATE_BIT);
  

• if (ret < 0)

• dev_err(cdns->dev, "Config update timedout\n");
  
  

• return ret;

• return 0; } EXPORT_SYMBOL(sdw_cdns_enable_interrupt);

Rather than ignoring _cdns_enable_interrupt - despite said func always returning 0 - simply do: return _cnds_enable_interrupt(cdns) and flag caller with inline.

Afterwards, one can think if such encapsulation is even required - remove existing sdw_cdns_enable_interrupt and rename _cnds_enable_interrupt?