4 Sep
2008
4 Sep
'08
2:37 p.m.
On Thu, Sep 04, 2008 at 04:22:03PM +0800, Bryan Wu wrote:
From: Cliff Cai cliff.cai@analog.com
Signed-off-by: Bryan Wu cooloney@kernel.org Signed-off-by: Cliff Cai cliff.cai@analog.com
Acked-by: Mark Brown broonie@opensource.wolfsonmicro.com
A couple of coding standards nits below but please fix these as an incremental patch to save on reviewing.
- if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
curr = sport_curr_offset_tx(sport) / sizeof(struct ac97_frame);- else {
curr = sport_curr_offset_rx(sport) / sizeof(struct ac97_frame);- }
Don't need the { }.
- ret = snd_pcm_hw_constraint_integer(runtime, \
SNDRV_PCM_HW_PARAM_PERIODS);- if (ret < 0)
goto out;
No need for the line continuation here.