On Fri, Apr 04, 2014 at 05:43:12PM +0800, Xiubo Li-B47053 wrote:
Subject: Re: [PATCH 1/2] ASoC: fsl_sai: Add clock control for SAI
Hi Xiubo,
On Fri, Apr 04, 2014 at 05:24:39PM +0800, Xiubo Li-B47053 wrote:
Hi,
I have test this series on my Vybrid-TWR board and it works happily.
You just checked the wrong version. I've sent a mail to let people disregard this version and a newer v2.
Sorry, I didn't receive these, I will search it in the web page.
[...]
diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c index 3847d2a..2d749df 100644 --- a/sound/soc/fsl/fsl_sai.c +++ b/sound/soc/fsl/fsl_sai.c @@ -428,5 +428,18 @@ static int fsl_sai_startup(struct snd_pcm_substream *substream, { struct fsl_sai *sai = snd_soc_dai_get_drvdata(cpu_dai);
- u32 reg;
- struct device *dev = &sai->pdev->dev;
- u32 reg, ret;
I'd prefer:
- int ret;
Just like last time I said, it would be converted to 'int' any way. There's no much difference between them.
Yes, it is...
I have ever encounter something like this in the feature maybe someone will do the following check:
If (ret < 0) ...
Just one potential problem and one suggestion.
Fine...I'll revise it as you wish..after you checked the v2.
Thanks, Nicolin