On Mon, Apr 23, 2018 at 09:15:10AM +0530, Sanyog Kale wrote:
On Sat, Apr 21, 2018 at 09:43:15PM +0530, Vinod Koul wrote:
On Sat, Apr 21, 2018 at 06:56:26AM -0700, Pierre-Louis Bossart wrote:
- if (!bus->params.bandwidth) {
bus->params.row = 0;bus->params.col = 0;goto exit;What is the intent with this test+goto? Shouldn't you program the parameters if you want to change the frame shape?
hmmm that seems correct point to me, but then we are going idle and should ideally power down. Let me check again if that is the reason.
We do not want to program parameters or change frame shape in case of bandwidth required is 0 on bus (ie. no stream running). The row and col values are reset to 0 and will be re-computed again in prepare_stream of next stream based on stream requirement.
Yes that is right
On Mon, Apr 23, 2018 at 08:30:47AM -0500, Pierre-Louis Bossart wrote:
what about clock stop? what about the default frame shape specified in the DisCo spec? I don't see the reason why we'd go to 48x2 - especially on Intel platforms where we'll typically use 50x2 to remain aligned with a 48kHz frame rate.
But as Pierre pointed out ut should be using DisCo defaults and not 48x2 in the bus. So I will remove this check and add a TODO for using DisCo value here
Thanks