Hi Viorel,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on asoc/for-next] [also build test WARNING on v5.0 next-20190304] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Viorel-Suman/Add-NXP-AUDMIX-device-... base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next config: nds32-allyesconfig (attached as .config) compiler: nds32le-linux-gcc (GCC) 6.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=6.4.0 make.cross ARCH=nds32
All warnings (new ones prefixed by >>):
In file included from include/linux/printk.h:331:0, from include/linux/kernel.h:14, from include/linux/clk.h:16, from sound/soc/fsl/fsl_audmix.c:8: sound/soc/fsl/fsl_audmix.c: In function 'fsl_audmix_state_trans': include/linux/dynamic_debug.h:80:13: error: initializer element is not constant .format = (fmt), \ ^ include/linux/dynamic_debug.h:111:2: note: in expansion of macro 'DEFINE_DYNAMIC_DEBUG_METADATA_KEY' DEFINE_DYNAMIC_DEBUG_METADATA_KEY(name, fmt, 0, 0) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/dynamic_debug.h:133:2: note: in expansion of macro 'DEFINE_DYNAMIC_DEBUG_METADATA' DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/device.h:1473:2: note: in expansion of macro 'dynamic_dev_dbg' dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~~~~~
sound/soc/fsl/fsl_audmix.c:93:3: note: in expansion of macro 'dev_dbg'
dev_dbg(comp->dev, prm.msg); ^~~~~~~ include/linux/dynamic_debug.h:80:13: note: (near initialization for 'descriptor.format') .format = (fmt), \ ^ include/linux/dynamic_debug.h:111:2: note: in expansion of macro 'DEFINE_DYNAMIC_DEBUG_METADATA_KEY' DEFINE_DYNAMIC_DEBUG_METADATA_KEY(name, fmt, 0, 0) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/dynamic_debug.h:133:2: note: in expansion of macro 'DEFINE_DYNAMIC_DEBUG_METADATA' DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/device.h:1473:2: note: in expansion of macro 'dynamic_dev_dbg' dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~~~~~
sound/soc/fsl/fsl_audmix.c:93:3: note: in expansion of macro 'dev_dbg'
dev_dbg(comp->dev, prm.msg); ^~~~~~~
vim +/dev_dbg +93 sound/soc/fsl/fsl_audmix.c
85 86 static int fsl_audmix_state_trans(struct snd_soc_component *comp, 87 unsigned int *mask, unsigned int *ctr, 88 const struct fsl_audmix_state prm) 89 { 90 struct fsl_audmix *priv = snd_soc_component_get_drvdata(comp); 91 /* Enforce all required TDMs are started */ 92 if ((priv->tdms & prm.tdms) != prm.tdms) {
93 dev_dbg(comp->dev, prm.msg);
94 return -EINVAL; 95 } 96 97 switch (prm.clk) { 98 case 1: 99 case 2: 100 /* Set mix clock */ 101 (*mask) |= FSL_AUDMIX_CTR_MIXCLK_MASK; 102 (*ctr) |= FSL_AUDMIX_CTR_MIXCLK(prm.clk - 1); 103 break; 104 default: 105 break; 106 } 107 108 return 0; 109 } 110
--- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation