On Monday 12 March 2018 11:55 PM, Mark Brown wrote:
On Mon, Mar 12, 2018 at 12:04:14PM +0530, Vijendar Mukunda wrote:
* It has fixed mapping as mentioned below.* designware-i2s.1.auto cpu dai will be used for I2S SP Instance playback device.* designware-i2s.2.auto cpu dai will be used for I2S SP Instance capture device.* designware-i2s.3.auto cpu dai will be used for I2S BT Instance playback/capture device.I'm still not thrilled about this. If we're hard coding names they should be explicitly assigned names so that there's less chance that some other change in the subsystem will change things.
AMD Gpu driver creates devices for Playback and capture devices for both the I2S Controller instances using MFD framework. Designware driver probe call gets invoked for every device creation with resource information and platform data provided by GPU driver. In runtime , it seems exporting the device resource name from dwc driver to acp dma driver is not possible. We understand your concern, but we have made the all necessary checks to avoid any fall-backs due to this. Our design makes sure that the same naming convention is followed in machine driver too and there also we mention cpu dai name in the same way. We explored other options but this seems to be the best which makes acp dma driver compatible with multiple platforms.
Please make some effort to keep the code within 80 columns too.
We will fix it and share updated patch.