Re: [alsa-devel] [PATCH V2 01/10] ASoc: mxs: add mxs-pcm driver

13 Jul 2011

      ...
-----Original Message-----
From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com]
Sent: Wednesday, July 13, 2011 7:27 AM
To: Dong Aisheng-B29396
Cc: alsa-devel@alsa-project.org; linux-arm-kernel@lists.infradead.org;
lrg@ti.com; s.hauer@pengutronix.de; u.kleine-koenig@pengutronix.de
Subject: Re: [PATCH V2 01/10] ASoc: mxs: add mxs-pcm driver
On Tue, Jul 12, 2011 at 11:04:36PM +0800, Dong Aisheng wrote:
...

if (dai->driver->capture.channels_min) {
ret = mxs_pcm_preallocate_dma_buffer(pcm,

	SNDRV_PCM_STREAM_CAPTURE);

if (ret)

	goto out;

}

For robustness replace the channels_min check with a check for the
relevant substream being present (see pxa2xx-pcm.c for a recent example).
Thanks for the reminder.
I will check it.
Regards
Dong Aisheng