Re: [PATCH 09/10] ASoC: wm_adsp: simplify return value

11 Mar 2021


      On Wed, Mar 10, 2021 at 06:43:31PM -0600, Pierre-Louis Bossart wrote:
...
cppcheck warning:
sound/soc/codecs/wm_adsp.c:2092:9: warning: Identical condition and
return expression 'ret', return value is always 0
[identicalConditionAfterEarlyExit]
 return ret;
        ^
sound/soc/codecs/wm_adsp.c:2070:6: note: If condition 'ret' is true,
the function will return/exit
 if (ret)
     ^
sound/soc/codecs/wm_adsp.c:2092:9: note: Returning identical
expression 'ret'
 return ret;
        ^
Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com
Acked-by: Charles Keepax ckeepax@opensource.cirrus.com
Thanks,
Charles