Re: [PATCH 2/2] ASoC: rt5682: remove noisy debug messages

On Tue, Mar 17, 2020 at 3:35 PM shumingf@realtek.com wrote:

Some debug messages are too noisy. This patch removes it.

Suggest to use other words. For example, title: "ASoC: rt5682: make output message less verbose"; message: "Makes output message less verbose by reducing the log severity".

    for (i = 0; i < size - 1; i++) {

•           pr_info("div[%d]=%d\n", i, div[i]);
  

•           dev_dbg(rt5682->component->dev, "div[%d]=%d\n", i, div[i]);
            if (target * div[i] == rt5682->sysclk)
                    return i;
            if (target * div[i + 1] > rt5682->sysclk) {
  

•                   pr_err("can't find div for sysclk %d\n",
  

•                   dev_dbg(rt5682->component->dev, "can't find div for sysclk %d\n",
                            rt5682->sysclk);
  

Looking at around of the file, use pr_debug( ) here could be more consistent.