Le dimanche 11 mars 2012 11:38:48 Mark Brown a écrit :
On Fri, Mar 09, 2012 at 03:55:13PM +0100, Philippe Rétornaz wrote:
From: Sascha Hauer s.hauer@pengutronix.de
sha 20111307:
- rebased to 3.0-rc2
- implement tdm slot settings
- made it work with single ssi port
- more register names instead of hardcoded numbers
philippe 20120803:
- Add headset detection
- add mic2 bias
- enable headset output by default
If including stuff like this please include it after the ---. Things like notes about the odd arrangements with the SSI ports which will have ongoing meaning are much more useful in the changelog.
Overall this looks fairly clean but very out of date, for example there's a custom register cache impelementation and no DAPM.
Thank you for this detailed review. I will redo the patch based on your comments. I had a quick look at DAPM (dapm.txt in asoc documentation), but is there any good "reference" implementation which is in the kernel where I could have a look ?
Thanks,
Philippe