On 02/26/18 20:47, Mark Brown wrote:
On Mon, Feb 26, 2018 at 07:34:07PM +0100, Kirill Marinushkin wrote:
- The suggested commit breaks the existing ASoC.
The existing functionality already works with several existing ASoC by Intel. The suggested commit will break it for the following reason: The ALSA topology mechanism loads the binary topology file into ASoC. The suggested commit modifies the parser, but the binaries are already created for the existing functionality. As a result, all existing binaries will be parsed incorrectly.
Are there actual binaries using the existing code or is that just theoretical? My impression was that this was fixing things for existing binaries which were shipped for non-mainline kernels, is that not the case?
There is an actual conf, which can be converted into an actual binary: `alsa-lib/src/conf/topology/broadwell/broadwell.conf`
Theoretically, there can be an unknown number of the binaries, not available publicly.
Broadwell exists for a long time, and there is no way to be sure that all the theoretically existing binaries are modified together with this kernel patch.