-----Original Message----- From: Mark Brown [mailto:broonie@kernel.org] Sent: Tuesday, April 08, 2014 7:06 PM To: Oder Chiou Cc: lgirdwood@gmail.com; alsa-devel@alsa-project.org; Bard Liao; Flove Subject: Re: [PATCH] ASoC: rt5640: add rt5639 support
On Tue, Apr 08, 2014 at 11:32:09AM +0800, Oder Chiou wrote:
-static const SOC_ENUM_SINGLE_DECL(rt5640_if1_dac_enum,
RT5640_DIG_INF_DATA,
RT5640_IF1_DAC_SEL_SFT, rt5640_data_select);+static SOC_ENUM_SINGLE_DECL(rt5640_if1_dac_enum,
RT5640_DIG_INF_DATA,
- RT5640_IF1_DAC_SEL_SFT, rt5640_data_select);
This seems to contain a lot of changes like this which are purely coding style changes rather than actual code changes. As far as I can tell the majority of this change is coding style or comment changes. Can you please split these out into separate commits, it is much harder to review if it's hard to find the active changes. There's nothing wrong with the stylistic stuff particularly but it should be done as separate changes.
We will follow your recommendation and resend the patch.