At Fri, 7 Feb 2014 11:35:30 +0800, Hsin-Yu Chao wrote:
The Chromebook Pixel has a microphone under the keyboard that is attached to node id 0x8. Before this fix, recording would always go to the main internal mic (node id 0x7).
Signed-off-by: Hsin-Yu Chao hychao@chromium.org Reviewed-by: Dylan Reid dgreid@chromium.org
The description doesn't state why it fixes what: the patch is actually a fix for the wrong ADC pickup in ca0132_capture_pcm_prepare() where it assumes wrongly the multiple streams although the driver implements one stream per ADC. (And, ca0132_capture_pcm_cleanup() already does the right thing.)
Could you rephrase the patch description and resend?
thanks,
Takashi
sound/pci/hda/patch_ca0132.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c index 59104dc..d5aabce 100644 --- a/sound/pci/hda/patch_ca0132.c +++ b/sound/pci/hda/patch_ca0132.c @@ -2770,9 +2770,7 @@ static int ca0132_capture_pcm_prepare(struct hda_pcm_stream *hinfo, unsigned int format, struct snd_pcm_substream *substream) {
- struct ca0132_spec *spec = codec->spec;
- snd_hda_codec_setup_stream(codec, spec->adcs[substream->number],
snd_hda_codec_setup_stream(codec, hinfo->nid, stream_tag, 0, format);
return 0;
-- 1.9.0.rc1.175.g0b1dcb5