Re: [PATCH] ASoC: dt-bindings: renesas: adjust to R-Car Gen4

6 Feb 2023


      Hi Krzysztof
Thank you for your review
...
This does not make sense - you just require it always.
(snip)
...
Please do not embed if within another if, unless strictly necessary. It
gets unmanageable.
(snip)
...
minItems
(snip)
...
Drop
OK, thanks. Will fix in v2
...
...
The "required" with if - then - else on "rcar_sound,ssi" is
always match to "then" even though it is checking "renesas,rcar_sound-gen4" or not.
Why ?? Is it my fault ??
I'm not sure why but some "if - then - else" doesn't work correctly for me.
One concern is that it is under "patternProperties".
Non "patternProperties" case is works well.
This is just sample case.
In below case, only gen4 case requires "foo/bar" if my understanding was correct.
But I get error "foo/bar are required" on *all* compatible.
It is my fault ?
--- sample -----------
  rcar_sound,ssi:
    ...
    patternProperties:
      "^ssi-[0-9]$":
        ...
        allOf:
          - if:
              properties:
                compatible:
                  contains:
=>                  const: renesas,rcar_sound-gen4
            then:
              required:
=>              - foo
=>              - bar
-----------------------
Thank you for your help !!
Best regards
---
Kuninori Morimoto