Re: [PATCH] ASoC: fsl_asrc: Add initialization finishing check in runtime resume

On Mon, Sep 5, 2022 at 6:54 PM Shengjiu Wang shengjiu.wang@gmail.com wrote:

...

...

•   /* Wait for status of initialization for every enabled pairs */
  

•   do {
  

•           udelay(5);
  

•           regmap_read(asrc->regmap, REG_ASRCFG, &reg);
  

•           reg = (reg >> ASRCFG_INIRQi_SHIFT(0)) & 0x7;
  

•   } while ((reg != ((asrctr >> ASRCTR_ASRCEi_SHIFT(0)) & 0x7)) && --retry);
  

•   /* FIXME: Doesn't treat initialization timeout as error */
  

•   if (!retry)
  

•           dev_warn(dev, "initialization isn't finished\n");
  

Any reason why not just dev_err?

Just hesitate to use dev_err. if use dev_err, then should return an error. May one of the pairs is finished, it still can continue.

Makes sense. In that case, why "FIXME" :)