Re: [PATCH] ASoC: rt5665: add missed regulator_bulk_disable

1 Aug 2023

      在 2023年7月23日星期日 CST 下午11:12:17，Mark Brown 写道：
...
On Sun, Jul 23, 2023 at 03:07:31PM +0800, Zhang Shurong wrote:
...

ret = devm_add_action_or_reset(&i2c->dev,

rt5665_i2c_disable_regulators,
...
...

	rt5665);

if (ret)

return ret;

ret = regulator_bulk_enable(ARRAY_SIZE(rt5665->supplies),
	    rt5665->supplies);

if (ret != 0) {

This will attempt to disable the regulators if the initial enable fails
which is a bug.
You are right. I will move this to rt5663_i2c_remove() in next version.