At Sun, 25 Mar 2007 21:35:53 +0200, Michal Piotrowski wrote:
Hi Rene,
Rene Herman napisał(a):
On 03/25/2007 05:50 PM, Michal Piotrowski wrote:
This patch is against the latest -mm snapshot.
The maintainers of the drivers you submitted these against are in a better position to comment but generally I wish people wouldn't do this.
Disabled code normally serves as a reminder of how things either should or could be done, sometimes how they were done before, but aren't done currently and the developer made them into a comment for the reason of maybe wanting to revisit that decision later.
It's not in the way. With a possible exception for some really old cruft that's just sitting there taking up space in drivers that aren't being maintained, I believe this should generally be left alone.
Rene.
I think, that nobody cares about this '#if 0's
The drivers that aren't currently being developed don't mean that there will be someone to develop in future.
Many #if 0's are there for future extensions or for the current workarounds. Hence I prefer keeping them with proper comments. Let driver authors add comments there instead of blindly killing.
Takashi