Re: [alsa-devel] ALC298 headset mode support

At Mon, 11 May 2015 08:30:28 +0000, Kailang wrote:

Hi Takashi,

I finished the alc298 headset mode supported. But it only tested via our develop system.

....

@@ -3801,6 +3804,8 @@ static void alc_headset_mode_ctia(struct hda_codec *codec) case 0x10ec0283: alc_process_coef_fw(codec, coef0233); break;

• case 0x10ec0298:

• alc_update_coef_idx(codec, 0x8e, 0x0070, 0x0020);
  

  case 0x10ec0286:

I suppose you didn't forget break in the above, right? If so, add a comment like /* fallthrough */ to indicate that it's the intentional code. Ditto for other similar lines.

thanks,

Takashi