Thanks for your comments, Broonie.
-----Original Message----- From: Mark Brown broonie@kernel.org Sent: Monday, May 5, 2025 6:35 PM To: Ding, Shenghao shenghao-ding@ti.com Cc: andriy.shevchenko@linux.intel.com; tiwai@suse.de; 13916275206@139.com; 13564923607@139.com; alsa-devel@alsa- project.org; Xu, Baojun baojun.xu@ti.com Subject: [EXTERNAL] Re: [PATCH v4] ASoC: tas2781: Add a debufs node for acoustic tuning
On Mon, May 05, 2025 at 09:19:49AM +0800, Shenghao Ding wrote:
"Acoustic Tuning" debufs node is a bridge to the acoustic tuning tool which can tune the chips' acoustic effect.
include/sound/tas2781.h | 16 ++++ sound/soc/codecs/Kconfig | 16 ++++ sound/soc/codecs/tas2781-i2c.c | 154 +++++++++++++++++++++++++++++++++
One of the key things about the define that's used for the regmap API version of this is that it's not visible in Kconfig, you have to edit the kernel source due to the whole directly exposing the registers things. It'd be too easy for a distro or something to just turn the define on by mistake otherwise. That's why it's a define in the code instead. The code itself looks fine.
I need to drop the following setting in Kconfig, right? +if SND_SOC_TAS2781_I2C + +config SND_SOC_TAS2781_I2C_ACOUST ......................... +endif ## SND_SOC_TAS2781_I2C +
As to REGMAP API, when enabling SND_SOC_TAS2781_COMLIB_I2C will select REGMAP_I2C. And enabling SND_SOC_TAS2781_I2C will select SND_SOC_TAS2781_COMLIB_I2C. So whether SND_SOC_TAS2781_I2C_ACOUST is enabled or not, REGMAP_I2C is selected.